Fix "Audio buffer is not finite everywhere" by force initializing buffer for spec_s#1359
Open
lspr98 wants to merge 1 commit into
Open
Fix "Audio buffer is not finite everywhere" by force initializing buffer for spec_s#1359lspr98 wants to merge 1 commit into
lspr98 wants to merge 1 commit into
Conversation
This was referenced Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializing spec_s with np.ndarray can contain Nan / Inf according to the numpy docs, since it does not overwrite the underlying buffer memory. This causes the "Audio buffer is not finite everywhere" error in cmb_spectrogram_to_wave, as already reported in multiple issues (#1021, #1045, #1147, #1153, #1262, to name a few). Initializing with np.zeros populates the buffer with zeros, avoiding the issue.