Skip to content

ZLIB: version bug fix#14387

Merged
lj0919 merged 1 commit into
ApolloAuto:masterfrom
lx18233184051:apollo_bug_fix
Mar 31, 2022
Merged

ZLIB: version bug fix#14387
lj0919 merged 1 commit into
ApolloAuto:masterfrom
lx18233184051:apollo_bug_fix

Conversation

@lx18233184051
Copy link
Copy Markdown
Contributor

Change-Id: Ie9b38d91bd11410bc78a2d48e676234f35b51816

Change-Id: Ie9b38d91bd11410bc78a2d48e676234f35b51816
@daohu527
Copy link
Copy Markdown
Contributor

It's better maintain the previous version as well like 5.0.0 and 6.0.0

@ntutangyun
Copy link
Copy Markdown

this does not solve for r6.0.0

@daohu527
Copy link
Copy Markdown
Contributor

@ntutangyun In apollo 6.0, We should move the configuration to the front

load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()

http_archive(
    name = "zlib",
    build_file = "@com_google_protobuf//:third_party/zlib.BUILD",
    sha256 = "629380c90a77b964d896ed37163f5c3a34f6e6d897311f1df2a7016355c45eff",
    strip_prefix = "zlib-1.2.11",
    urls = ["https://github.com/madler/zlib/archive/v1.2.11.tar.gz"],
)

GowthamKudupudi pushed a commit to amd/apollo that referenced this pull request Nov 17, 2022
YanXuechun pushed a commit to YanXuechun/Xuechun that referenced this pull request Oct 16, 2025
[Synopsis] The new version of `zlib` - zlib-1.2.12 is released (https://zlib.net/zlib-1.2.12.tar.gz), the previous version of `zlib` became unavailable (https://zlib.net/zlib-1.2.11.tar.gz)

[Solution]
Get the previous `zlib` version from `zlib/archive`

[IMP] It would definitely be better to cherry-pick the fix (ApolloAuto/apollo#14387) from the vanilla Apollo

[Error log] `./apollo.sh build`
```
...
(10:53:17) ERROR: /apollo/modules/localization/msf/local_pyramid_map/base_map/BUILD:22:11: //modules/localization/msf/local_pyramid_map/base_map:base_map_matrix depends on @zlib//:zlib in repository @zlib which failed to fetch. no such package '@zlib//': java.io.IOException: Error downloading [https://zlib.net/zlib-1.2.11.tar.gz] to /apollo/.cache/bazel/540135163923dd7d5820f3ee4b306b32/external/zlib/temp165233950568194062/zlib-1.2.11.tar.gz: GET returned 404 Not Found
(10:53:17) ERROR: Analysis of target '//modules/localization/msf/local_pyramid_map/base_map:base_map_matrix' failed; build aborted: Analysis failed
(10:53:17) INFO: Elapsed time: 20.380s
(10:53:17) INFO: 0 processes.
(10:53:17) FAILED: Build did NOT complete successfully (672 packages loaded, 1\
1323 targets configured)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants