Expose Randomizer property and use it in retry strategy#1346
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1346 +/- ##
==========================================
+ Coverage 83.58% 83.59% +0.01%
==========================================
Files 270 270
Lines 6389 6396 +7
Branches 1008 1008
==========================================
+ Hits 5340 5347 +7
Misses 840 840
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
This PR exposes
ResilienceStrategyBuilder.Randomizer(altought hidden for now) that allows to control the randomization behavior in tests. Additionally, I have fixed the copy constructor which omitted some properties.This change also allows (with some tricks) to calculate the aggregated delays of retry strategy.
I will use this here instead of custom code:
https://github.com/dotnet/extensions/blob/52ebc1b123613254f9dfe250515027c1332fba35/src/Libraries/Microsoft.Extensions.Http.Resilience/Resilience/Internal/Validators/ValidationHelper.cs#L13
Confirm the following