Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
+ Coverage 83.68% 83.70% +0.02%
==========================================
Files 269 270 +1
Lines 6429 6438 +9
Branches 1004 1005 +1
==========================================
+ Hits 5380 5389 +9
Misses 840 840
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Jul 4, 2023
Member
martincostello
left a comment
There was a problem hiding this comment.
The changes look ok, but from the tests I don't understand how the rate limiter would partition on the HTTP context, for example, where the limit is intended to be per client on a particular strategy pipeline.
Contributor
Author
Let me create an more complex issue test that demonstrates this in follow-up. |
This was referenced Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Implements the following proposal that adds support for
PartitionedRateLimiter:#1365 (comment)
Confirm the following