Skip to content

Improve samples#1467

Merged
martintmk merged 1 commit intomainfrom
mtomka/improve-samples
Aug 9, 2023
Merged

Improve samples#1467
martintmk merged 1 commit intomainfrom
mtomka/improve-samples

Conversation

@martintmk
Copy link
Copy Markdown
Contributor

@martintmk martintmk commented Aug 9, 2023

Details on the issue fix or feature implementation

Just fixing some issues I noticed while playing with latest samples.

  • Renamed remnants of ResilienceStrategyBuilder to CompositeStrategyBuilder
  • Timeout had some invalid values assigned, changing these to valid ones.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 9, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 9, 2023
@martintmk martintmk self-assigned this Aug 9, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1467 (dc92a08) into main (7aa1344) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1467   +/-   ##
=======================================
  Coverage   83.89%   83.89%           
=======================================
  Files         275      275           
  Lines        6495     6495           
  Branches     1015     1015           
=======================================
  Hits         5449     5449           
  Misses        837      837           
  Partials      209      209           
Flag Coverage Δ
linux 83.89% <ø> (ø)
macos 83.89% <ø> (ø)
windows 83.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martintmk martintmk merged commit 3d8d6f4 into main Aug 9, 2023
@martintmk martintmk deleted the mtomka/improve-samples branch August 9, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants