Skip to content

Cleanup ResiliencePipelineRegistry internals#1510

Merged
martintmk merged 2 commits intomainfrom
mtomka/cleanup-reqistry-internals
Aug 23, 2023
Merged

Cleanup ResiliencePipelineRegistry internals#1510
martintmk merged 2 commits intomainfrom
mtomka/cleanup-reqistry-internals

Conversation

@martintmk
Copy link
Copy Markdown
Contributor

@martintmk martintmk commented Aug 23, 2023

Details on the issue fix or feature implementation

  • ConfigureBuilderContext should not be cached, instead re-created per each call.
  • Moved PipelineComponent construction to a separate class.

No public changes.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 23, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 23, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1510 (4079573) into main (a61b343) will increase coverage by 0.07%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
+ Coverage   83.86%   83.93%   +0.07%     
==========================================
  Files         272      274       +2     
  Lines        6481     6511      +30     
  Branches     1020     1018       -2     
==========================================
+ Hits         5435     5465      +30     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux 83.93% <100.00%> (+0.07%) ⬆️
macos 83.93% <100.00%> (+0.07%) ⬆️
windows 83.93% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
....Core/Registry/RegistryPipelineComponentBuilder.cs 100.00% <100.00%> (ø)
...ore/Registry/ResiliencePipelineRegistry.TResult.cs 100.00% <100.00%> (ø)
.../Polly.Core/Registry/ResiliencePipelineRegistry.cs 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@martintmk martintmk merged commit 32a3390 into main Aug 23, 2023
@martintmk martintmk deleted the mtomka/cleanup-reqistry-internals branch August 23, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants