Skip to content

Drop unused internal property#1532

Merged
martintmk merged 1 commit intomainfrom
mtomka/drop-unused-property
Aug 31, 2023
Merged

Drop unused internal property#1532
martintmk merged 1 commit intomainfrom
mtomka/drop-unused-property

Conversation

@martintmk
Copy link
Copy Markdown
Contributor

@martintmk martintmk commented Aug 31, 2023

Details on the issue fix or feature implementation

Could fix coverage issues in #1144

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 31, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 31, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (a7cb07c) 83.93% compared to head (3e5b81b) 83.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1532      +/-   ##
==========================================
- Coverage   83.93%   83.92%   -0.02%     
==========================================
  Files         279      279              
  Lines        6523     6518       -5     
  Branches     1017     1017              
==========================================
- Hits         5475     5470       -5     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 83.92% <100.00%> (-0.02%) ⬇️
macos 83.92% <100.00%> (-0.02%) ⬇️
windows 83.92% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
....Core/Registry/RegistryPipelineComponentBuilder.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk merged commit 5168ecb into main Aug 31, 2023
@martintmk martintmk deleted the mtomka/drop-unused-property branch August 31, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants