Skip to content

Fix Name and InstanceName not being set for reloadable pipelines#1555

Merged
martintmk merged 7 commits intomainfrom
mtomka/telemetry-test
Sep 6, 2023
Merged

Fix Name and InstanceName not being set for reloadable pipelines#1555
martintmk merged 7 commits intomainfrom
mtomka/telemetry-test

Conversation

@martintmk
Copy link
Copy Markdown
Contributor

@martintmk martintmk commented Sep 6, 2023

Details on the issue fix or feature implementation

Closes #1547

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 6, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 6, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3f1b435) 83.92% compared to head (d3112e8) 83.92%.
Report is 2 commits behind head on main.

❗ Current head d3112e8 differs from pull request most recent head 90f188e. Consider uploading reports for the commit 90f188e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1555   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files         279      279           
  Lines        6518     6518           
  Branches     1017     1017           
=======================================
  Hits         5470     5470           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.92% <ø> (ø)
windows 83.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk changed the title Add test that verifies PipelineInstanceName in telemetry Fix Name and InstanceName not being set for reloadable pipelines Sep 6, 2023
@martintmk martintmk enabled auto-merge (squash) September 6, 2023 15:10
@martintmk martintmk merged commit bc07c7c into main Sep 6, 2023
@martintmk martintmk deleted the mtomka/telemetry-test branch September 6, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Default logging behaviour when using InstanceName is unintuitive

2 participants