[Docs] Use docfx to dynamically render mermaid diagrams#1701
Merged
martintmk merged 2 commits intoApp-vNext:mainfrom Oct 17, 2023
Merged
[Docs] Use docfx to dynamically render mermaid diagrams#1701martintmk merged 2 commits intoApp-vNext:mainfrom
martintmk merged 2 commits intoApp-vNext:mainfrom
Conversation
martincostello
approved these changes
Oct 16, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1701 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 306 306
Lines 6819 6819
Branches 1045 1045
=======================================
Hits 5771 5771
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
After scrutinizing the relevant documentation it turned out mermaid is supported by the modern template. I checked it locally and it works. I'm repurposing this PR to enable mermaid diagrams. |
auto-merge was automatically disabled
October 17, 2023 07:24
Head branch was pushed to by a user without write access
peter-csala
changed the title
|
|
||
| <!-- ```mermaid | ||
| ```mermaid | ||
| %%{init: {'theme':'dark'}}%% |
Member
There was a problem hiding this comment.
I don't use the dark theme, and these diagrams don't look good:
4 tasks
This was referenced Sep 29, 2025
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
Details on the issue fix or feature implementation
Proof
Note: The built-in themes are either optimized for white or black background. Only the dark is legible in both cases
Dark theme
Light theme
Confirm the following