Fix SA1618 by documenting typeparams#2078
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 312 312
Lines 7114 7114
Branches 1054 1054
=======================================
Hits 5954 5954
Misses 789 789
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@martincostello And since this PR it runs on MacOS v14: when I reverted to Not sure why tests on MacOS 14 are failing. Logs don't tell much, except that it fails during testing. Maybe it's related to Apple's M1 CPU architecture, but I don't have M1 to test further. So what should we do here? |
|
Thanks for working out the version change is why it's failing. This PR will have to wait until we can investigate and fix our CI for macOS 14. |
|
If you rebase once #2079 is merged, things should work again 👍 |
|
If you rebase things should be fixed now. |
|
Thanks! My fork is synced now. |
Pull Request
The issue or feature being addressed
#1290
Details on the issue fix or feature implementation
typeparamdescription to missing filesConfirm the following