Conversation
Apply recommendations/fixes suggested by Copilot in #2830.
There was a problem hiding this comment.
Pull request overview
This PR applies fixes to property-based tests that were previously recommended in PR #2830, correcting test specifications and fixing a pragma directive issue.
- Corrected property-based test assertions to properly handle edge cases where values can equal boundaries
- Fixed test range calculations to accurately reflect actual implementation behavior
- Fixed mismatched pragma warning directive
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Polly.Core.Tests/Retry/RetryHelperTests.cs | Corrected jitter delta calculation from /2 to /4, updated assertions to use ShouldBeGreaterThanOrEqualTo for edge cases, set floor to TimeSpan.Zero for DecorrelatedJitterBackoffV2 test, and changed maximum test value to 2048 (power of 2) |
| src/Polly.Core/Retry/RetryHelper.cs | Fixed pragma warning directive from disable to restore to properly close the warning suppression block |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2831 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 309 309
Lines 7123 7123
Branches 1005 1005
=======================================
Hits 6849 6849
Misses 221 221
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Apply recommendations/fixes suggested by Copilot in #2830.