Conversation
martincostello
commented
Feb 13, 2026
- Update F# and VB examples from .NET 9 to .NET 10.
- Suppress new code analysis warnings.
- Use primary constructor.
- Update F# and VB examples from .NET 9 to .NET 10. - Suppress new code analysis warnings. - Use primary constructor.
There was a problem hiding this comment.
Pull request overview
Prepares the repository for newer .NET SDK/analyzer behavior by updating sample target frameworks, adjusting analyzer suppressions, and adopting a C# primary-constructor pattern in benchmarks.
Changes:
- Bump F# and VB sample projects from
net9.0tonet10.0. - Suppress new analyzer warnings (project-level
CA1510;CA1010/CA1710aroundContextdictionary implementation). - Refactor benchmark cache provider to use a primary constructor.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Polly.Specs/Helpers/Caching/StubSerialized.cs | Doc comment punctuation tweak in test helper. |
| src/Polly/Polly.csproj | Adds CA1510 to global NoWarn list. |
| src/Polly/Context.Dictionary.cs | Adds targeted pragma suppression for CA1010/CA1710 on Context dictionary partial. |
| samples/Intro.VisualBasic/Intro.VisualBasic.vbproj | Updates sample TFM to net10.0. |
| samples/Intro.FSharp/Intro.FSharp.fsproj | Updates sample TFM to net10.0. |
| bench/Polly.Benchmarks/Cache.cs | Uses a primary constructor for the benchmark cache provider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 309 309
Lines 7128 7128
Branches 1005 1005
=======================================
Hits 6854 6854
Misses 221 221
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |