Skip to content

build(deps): bump io.nlopez.compose.rules:detekt from 0.4.5 to 0.4.8 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MessiasLima merged 2 commits into from
Aug 1, 2024
Merged

build(deps): bump io.nlopez.compose.rules:detekt from 0.4.5 to 0.4.8 #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
067e041
build(deps): bump io.nlopez.compose.rules:detekt from 0.4.5 to 0.4.8
dependabot[bot] Jul 30, 2024
f3c6922
fix: error screen
MessiasLima Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ voyager = "1.0.0"

[libraries]
appdirs = "ca.gosyer:kotlin-multiplatform-appdirs:1.2.0"
detekt-compose = "io.nlopez.compose.rules:detekt:0.4.5"
detekt-compose = "io.nlopez.compose.rules:detekt:0.4.8"
detekt-formatting = { module = "io.gitlab.arturbosch.detekt:detekt-formatting", version.ref = "detekt" }
flatlaf = "com.formdev:flatlaf:3.5"
joda-time = "joda-time:joda-time:2.12.7"
Expand Down
19 changes: 17 additions & 2 deletions src/main/kotlin/appoutlet/gameoutlet/feature/common/composable/Error.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package appoutlet.gameoutlet.feature.common.composable

import androidx.compose.desktop.ui.tooling.preview.Preview
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Spacer
Expand All @@ -12,7 +13,9 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.testTag
import androidx.compose.ui.text.style.TextAlign
import appoutlet.gameoutlet.core.translation.i18n
import appoutlet.gameoutlet.core.ui.GameOutletTheme
import appoutlet.gameoutlet.core.ui.spacing

@Composable
Expand All @@ -34,13 +37,16 @@ fun Error(
style = MaterialTheme.typography.titleLarge
)

Spacer(modifier = Modifier.height(MaterialTheme.spacing.medium))

Text(
modifier = Modifier.semantics { testTag = "message" },
text = message,
style = MaterialTheme.typography.bodyMedium
style = MaterialTheme.typography.bodyMedium,
textAlign = TextAlign.Center
)

Spacer(modifier = Modifier.height(MaterialTheme.spacing.medium))
Spacer(modifier = Modifier.height(MaterialTheme.spacing.large))

onTryAgain?.let {
Button(modifier = Modifier.semantics { testTag = "button" }, onClick = onTryAgain) {
Expand All @@ -49,3 +55,12 @@ fun Error(
}
}
}

@Composable
@Preview
private fun ErrorPreview() {
GameOutletTheme {
Error {
}
}
}
12 changes: 6 additions & 6 deletions src/main/kotlin/appoutlet/gameoutlet/feature/wishlist/composable/WishlistContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,12 @@ private fun WishlistGames(
onInputEvent = onInputEvent,
)
}
}
}

if (uiState.list.isEmpty()) {
Box(modifier = Modifier.fillMaxSize(), contentAlignment = Alignment.Center) {
WishlistEmptyList(onInputEvent = onInputEvent)
} else {
item {
Box(contentAlignment = Alignment.Center) {
WishlistEmptyList(onInputEvent = onInputEvent)
}
}
}
}
}