Conversation
feat: allow tokens usage to be updated to 0 in agreements route
Tests difference:New Tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
PUT /dossiers/:id/agreementsendpoint to allow setting thetokensvalue to zero, and adds a corresponding test to ensure this behavior is handled correctly. The main changes are:Validation logic update:
RouteItemto allowtokensto be zero, only rejecting negative values instead of non-positive values. This enables settingtokensto zero via the API.Testing improvements:
tokensto zero is accepted and correctly updates the database, with the endpoint returning a 200 status.