UN-2278 post campaign supplier#512
Merged
Merged
Conversation
Tests difference:New Tests |
….json and package-lock.json
Collaborator
…sary request body and adjust response handling
…ed request and response schemas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new API endpoint for creating campaign finance suppliers, along with its implementation, OpenAPI documentation, schema updates, and comprehensive tests. The main focus is to allow authorized users to add new suppliers to a campaign, ensuring name uniqueness and proper permissions.
Key changes:
1. New API Endpoint for Creating Campaign Finance Suppliers
/campaigns/{campaign}/finance/supplierPOST endpoint to the OpenAPI spec, enabling creation of new suppliers for a campaign with validation for required fields and security responses.SupplierRoute, including permission checks, duplicate name prevention, and error handling.2. Testing
3. Schema Enhancements
These changes collectively introduce a robust and well-documented way to manage campaign finance suppliers via the API.