fix(expo): clean stale tools:replace entries when removing backup attributes

[matingathani]

Summary

Fixes a manifest merge failure that occurs when preferAppsFlyerBackupRules=true and another Expo plugin (e.g. expo-secure-store) has already added the removed backup attribute names to tools:replace.

When the plugin deletes android:dataExtractionRules or android:fullBackupContent from the app's manifest, any existing tools:replace entry referencing those same attribute names becomes stale. The Android manifest merger then fails with:

Multiple entries with same key: android:dataExtractionRules=REPLACE

Changes:

• Track which backup attributes were deleted (removedKeys).
• After deletion, filter stale attribute names out of any existing tools:replace value; delete tools:replace entirely if it becomes empty.
• Only mutate the attribute and emit the log when entries were actually removed (no-ops cleanly when tools:replace contains no stale entries).

Test plan

• preferAppsFlyerBackupRules=false (default): no manifest changes, no log output
• preferAppsFlyerBackupRules=true, app has no backup attributes: no manifest changes
• preferAppsFlyerBackupRules=true, app has backup attributes but no tools:replace: attributes removed, no tools:replace clean-up log
• preferAppsFlyerBackupRules=true, app has backup attributes + tools:replace containing those keys: attributes removed, stale keys filtered from tools:replace, log emitted
• preferAppsFlyerBackupRules=true, tools:replace contains only stale keys: entire tools:replace attribute deleted

[Copilot]

Pull request overview

This PR updates the Expo Android config plugin to prevent Android manifest merge failures caused by stale tools:replace entries after removing backup-related manifest attributes when preferAppsFlyerBackupRules=true.

Changes:

• Track removed backup-related attributes (android:dataExtractionRules, android:fullBackupContent) when opting into AppsFlyer backup rules.
• Remove any matching attribute names from tools:replace, deleting tools:replace entirely if it becomes empty.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The PR description mentions a Set-based deduplication of tools:replace, but this implementation only filters out removedKeys and does not dedupe remaining entries. Either update the description to match the code, or switch this logic to a Set-based normalize+filter so duplicate keys in tools:replace can’t persist and keep breaking manifest merge.

[matingathani]

Good catch on the description. Updated the PR body to say 'filters stale entries' instead of 'Set-based deduplication' — the code only removes the deleted attribute keys from tools:replace and does not otherwise deduplicate remaining entries.

[Copilot]

This log line will print whenever tools:replace exists, even if filtered is identical to the original value (i.e., nothing was actually cleaned). Consider only logging when a change was made, or include the removed keys in the log so it’s not misleading during debugging.

Suggested change

	const filtered = appAttrs['tools:replace']
	.split(',')
	.map((s) => s.trim())
	.filter((s) => s && !removedKeys.includes(s));
	if (filtered.length > 0) {
	appAttrs['tools:replace'] = filtered.join(', ');
	} else {
	delete appAttrs['tools:replace'];
	}
	console.log('[AppsFlyerPlugin] Cleaned stale tools:replace entries for removed backup attributes');
	const existingReplaceEntries = appAttrs['tools:replace']
	.split(',')
	.map((s) => s.trim())
	.filter(Boolean);
	const filtered = existingReplaceEntries.filter((s) => !removedKeys.includes(s));
	if (filtered.length !== existingReplaceEntries.length) {
	if (filtered.length > 0) {
	appAttrs['tools:replace'] = filtered.join(', ');
	} else {
	delete appAttrs['tools:replace'];
	}
	console.log('[AppsFlyerPlugin] Cleaned stale tools:replace entries for removed backup attributes');
	}

[matingathani]

Fixed in latest commit — now captures existingReplaceEntries before filtering, and only mutates the attribute and emits the log when filtered.length !== existingReplaceEntries.length (i.e. something was actually removed).