Addition of interfaces and classes for all request reponses#315
Open
patinoAlexis wants to merge 2 commits into
Open
Addition of interfaces and classes for all request reponses#315patinoAlexis wants to merge 2 commits into
patinoAlexis wants to merge 2 commits into
Conversation
Adding modifications to allow a better understanding of what the AccessRequestApi.js file is returning for each function and doing a more generic creation of interfaces and classes.
…ibility - Add `build` script using `babel src --out-dir dist --copy-files` so that `.d.ts` declaration files are copied alongside compiled JS into dist/ - Update `"main"` from `src/index.js` to `dist/index.js` so consumers receive CommonJS-compiled output instead of raw ES Modules source - Update `"types"` from `src/index.d.ts` to `dist/index.d.ts` so TypeScript resolves declarations from the built output, matching the JS entry point - Add `dist` to .gitignore Previously, `npm link` consumers would hit a SyntaxError at runtime (ES Module `import` in a CommonJS context) and TypeScript would fail to find type declarations because the `.d.ts` files were never included in the dist output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first commit with the general idea of seeing if you guys find it okay with the approach of creating the different classes and interfaces.
My main idea is to try to creating more interfaces and classes and for the moment concentrating of typing all the different type of results. For the moment only AccessRequestApi was done, but once you give i get your feedback my intention is doing it with every single Api file