This repository was archived by the owner on Sep 28, 2023. It is now read-only.
DappsStaking bench improvements#112
Merged
Merged
Conversation
Dinonard
suggested changes
Nov 9, 2022
|
|
||
| /// The current era index. | ||
| #[pallet::storage] | ||
| #[pallet::whitelist_storage] |
Collaborator
There was a problem hiding this comment.
Since we're doing this, please whitelist all necessary storage:
- PalletDisabled
- ForceEra
- NextEraStartingBlock
Contributor
Author
There was a problem hiding this comment.
That's true. I updated. thank you for pointing out
Dinonard
approved these changes
Nov 9, 2022
Collaborator
Dinonard
left a comment
There was a problem hiding this comment.
Great!
Please also bump the minor version in .toml file before merging.
Minimum allowed line rate is |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Dapps Staking
CurrentErastorage value is accessed byon_initializehook at every block.That means current era value is available in overlay cache, thus we can ignore storage access from benchmarking.
New attribute macro
#[pallet::whitelist_storage]registers Storage items to whitelists (which will be ignored in benchmarking), see more details paritytech/substrate#12205.This requires Astar repo updates too, but adding attribute can be done independently.
This PR fixes format issue as well
cargo fmt,taplo fmtto pass merge blocking.