fix: prevent unknown plugin reload from reloading all - #9556
Draft
AsahinaYui wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reload(None)reload-all behaviorRoot cause
PluginManager.reloadused the falsiness ofspecified_module_pathto select the reload-all path. An explicit unresolved plugin name left that value asNone, so the manager terminated and unbound every registered plugin before loading all plugins again.Impact
Reload requests for missing plugins now fail safely without terminating plugins, unbinding handlers, clearing registries, or invoking the loader.
Validation
uv run pytest tests/test_plugin_manager.py -k "reload_unknown_plugin" -q— 2 passeduv run pytest tests/test_plugin_manager.py -k "reload" -q— 12 passeduv run pytest tests/test_plugin_manager.py -q— 64 passeduv run ruff format --check astrbot/core/star/star_manager.py tests/test_plugin_manager.pyuv run ruff check astrbot/core/star/star_manager.py tests/test_plugin_manager.pygit diff --checkFixes #9546
Summary by Sourcery
Handle reload requests for unknown plugins safely without affecting existing plugins or registries.
Bug Fixes:
Tests: