Allow generating the pack without needing the server to be initialized.#48
Merged
iam4722202468 merged 2 commits intoAtlasEngineCa:masterfrom Jun 2, 2025
Merged
Conversation
Member
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class
ModelEnginehad a static block registering events to the global listener.This code was being executed even if one was just using
PackBuilder.Generatewithout having initialized the server, so I moved it at the beginning ofModelEngine.loadMappings.In my opinion, it would be useful to move this bit of code into a separate function
ModelEngine.addEventNode(eventNode), so that the user has to specify theEventNode. I also renamedPackBuilder.GeneratetoPackBuilder.generate.