fix: rename local variable to prevent shadowing of class field#10
Open
sonarqube-agent[bot] wants to merge 1 commit into
Open
fix: rename local variable to prevent shadowing of class field#10sonarqube-agent[bot] wants to merge 1 commit into
sonarqube-agent[bot] wants to merge 1 commit into
Conversation
Fixed issues: - AZZmtiWq2HDYqP_XyoAu for java:S1117 rule Generated by SonarQube Agent (task: 0e7917ba-1428-45e9-91f6-7edf0e726bad)
SonarQube reviewer guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Resolved a SonarQube MAJOR issue where a local variable named 'sourceFiles' was shadowing a class field of the same name. Renamed the local variable to 'sourceFileURLs' to eliminate the shadowing and provide a more descriptive name that better reflects its Set type, improving code clarity and preventing potential bugs from accidental field reference confusion.
View Project in SonarCloud
Fixed Issues
java:S1117 - Rename "sourceFiles" which hides the field declared at line 54. • MAJOR • View issue
Location:
core/src/main/java/com/webcohesion/enunciate/Enunciate.java:588Why is this an issue?
Shadowing occurs when a local variable has the same name as a variable or a field in an outer scope.
What changed
This is the primary fix for the variable shadowing issue. The local variable
sourceFilesat line 588 was shadowing the class fieldsourceFilesdeclared at line 54. By renaming the local variable fromsourceFilestosourceFileURLs, the shadowing is eliminated, giving the local variable a unique and more descriptive name that also better reflects its type (Set<URL>).SonarQube Remediation Agent uses AI. Check for mistakes.