Skip to content

fix: resolve SonarQube issues in pokedex helper exception handling #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve SonarQube issues in pokedex helper exception handling #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pokedex/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ def register_subscriber(self, email):
try:
self.__conn.execute("INSERT into SUBSCRIBERS(email) values (?)", (email,))
self.__conn.commit()
except sqlite3.DatabaseError:
raise Exception("Problem with the database!")
except sqlite3.IntegrityError:
raise ValueError("Email already exists!")
except sqlite3.DatabaseError:
raise RuntimeError("Problem with the database!")

def cleanup(self, should_close: bool):
if should_close:
Expand All @@ -33,6 +33,5 @@ def fetch_all_pokemons(wrapper: ConnectionWrapper):
def register_subscriber(wrapper: ConnectionWrapper, email):
pattern = re.compile(r"(.*)@(.*\..*)")
if not pattern.match(email):
ValueError("Invalid email!")
raise ValueError("Invalid email!")
wrapper.register_subscriber(email)
pass