Skip to content

Fix GeomType enum value and add missing return types to MeshGenerator #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sankalps0549 merged 2 commits into from
Dec 11, 2025
Merged

Fix GeomType enum value and add missing return types to MeshGenerator #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8189e89
Initial plan
Copilot Dec 10, 2025
357ecb5
Fix GeomType enum and add return types to MeshGenerator methods
Copilot Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/moldflow/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ class GeomType(Enum):
"""

AUTO_DETECT = "Auto-Detect"
DUAL_DOMAIN = "Dual Domain"
FUSION = "Fusion"
MIDPLANE = "Midplane"


Expand Down
10 changes: 8 additions & 2 deletions src/moldflow/mesh_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,22 @@ def __init__(self, _mesh_generator):
process_log(__name__, LogMessage.CLASS_INIT, locals(), name="MeshGenerator")
self.mesh_generator = safe_com(_mesh_generator)

def generate(self):
def generate(self) -> bool:
"""
Generate the mesh using the MeshGenerator instance.

Returns:
bool: True if mesh generation was successful, False otherwise.
"""
process_log(__name__, LogMessage.FUNCTION_CALL, locals(), name="generate")
return self.mesh_generator.Generate

def save_options(self):
def save_options(self) -> bool:
"""
Save the mesh generation options.

Returns:
bool: True if options were saved successfully, False otherwise.
"""
process_log(__name__, LogMessage.FUNCTION_CALL, locals(), name="save_options")
return self.mesh_generator.SaveOptions
Expand Down