Add support for tvOS target#336
Conversation
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
Took me a while to find the events from the demo app because:
- I had forgotten that the app by default doesn't actually send events (
shouldSendEvents = false) - I had forgotten Tracks Live View will not show events that are not registered unless you ask it to
But once I figured that out, I was able to see the events. All good.
| let package = Package( | ||
| name: "AutomatticTracksiOS", | ||
| platforms: [.macOS(.v10_14), .iOS(.v15)], | ||
| platforms: [.macOS(.v10_14), .iOS(.v15), .tvOS(.v15)], |
There was a problem hiding this comment.
Is v15 due to Sentry or other dependencies? It's quite old
https://developer.apple.com/documentation/packagedescription/supportedplatform/tvosversion
Having said that, so are the macOS and iOS versions, so maybe we can roll with it and update in a dedicated follow up for all of them.
There was a problem hiding this comment.
I just kept it inline with the other platforms. To be fair if it's compatible with that version I don't see a reason to push to a more recent version.
Regarding Sentry, will we need to change something to make it use a specific tvOs version of it?
The TracksDemoTests target only contains template app-hosted tests. Running it launches TracksDemo.app during the iOS lane, which adds demo bootstrap requirements without useful coverage. --- Generated with the help of Codex, https://openai.com/codex Co-Authored-By: Codex <noreply@openai.com>
CI creates the demo Secrets.swift from the sample file, which leaves the Sentry DSN empty. Use a valid dummy DSN so crash logging initialization does not abort demo app bootstrap. --- Generated with the help of Codex, https://openai.com/codex Co-Authored-By: Codex <noreply@openai.com>
Xcode 26.4.1 exposes mismatched SDK versions through xcodebuild and simctl, which breaks fastlane's automatic simulator detection. Pass the simulator destination directly to avoid that fastlane lookup. --- Generated with the help of Codex, https://openai.com/codex Co-Authored-By: Codex <noreply@openai.com>
Exercise fastlane simulator detection with the current iPhone simulator instead of bypassing scan with an explicit destination. --- Generated with the help of Codex CLI, https://openai.com/codex Co-Authored-By: Codex <noreply@openai.com>
This reverts commit bfbea36.
|
@mokagio do you understand why it fails the build-and-test-ios step? |
I came here to comment on that, actually. I looked into that yesterday (and I should have left a comment about it, sorry). Long story short, #338 fixes the issue and targets this PR. I enabled auto-merge, so once that's merged in here, this will land on |
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
Thanks again for working on this @SergioEstevao
2 participants
This PR adds support for the tvOS platform type in order to be used in the future Pocket Casts tvOs app.
Besides adding the necessary platform support and compiler checks it adds a demo app in order to test the sending of the events like the other platforms.
CHANGELOG.mdif necessary.