Skip to content

Use DSN instead of Dsn#372

Merged
mokagio merged 2 commits into
trunkfrom
copilot/wip-address-feedback-on-variable-naming
Jul 20, 2026
Merged

Use DSN instead of Dsn#372
mokagio merged 2 commits into
trunkfrom
copilot/wip-address-feedback-on-variable-naming

Conversation

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Thanks for the feedback on #371. I've created this new PR, which merges into #371, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #371
Triggering review: #371 (comment)

@copilot open a PR stacked on top of this one to tidy the variable name. I agree that sentryDSN should be the one in use, but changing it is out of scope for this particular PR.

Copilot AI requested a review from mokagio July 11, 2026 04:49
Base automatically changed from ainfra-2679-remove-secrets-from-tracks-demo to trunk July 18, 2026 02:32
@mokagio mokagio changed the title [WIP] [WIP] Address feedback on variable naming in Tracks demo PR Use DSN instead of Dsn Jul 20, 2026
@mokagio
mokagio marked this pull request as ready for review July 20, 2026 05:39
Copilot AI review requested due to automatic review settings July 20, 2026 05:39
@mokagio
mokagio enabled auto-merge July 20, 2026 05:39
@mokagio
mokagio disabled auto-merge July 20, 2026 05:39
@mokagio
mokagio merged commit 4fd7fff into trunk Jul 20, 2026
7 checks passed
@mokagio
mokagio deleted the copilot/wip-address-feedback-on-variable-naming branch July 20, 2026 05:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the Sentry DSN naming in the Tracks demo configuration with the preferred acronym capitalization (DSN), matching the existing sentryDSN usage in the crash logging provider interface.

Changes:

  • Renamed SentryConfig.sentryDsn to SentryConfig.sentryDSN.
  • Updated the demo crash logging data source to reference the renamed constant.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
TracksDemo/Shared/SentryConfig.swift Renames the Sentry DSN constant to use DSN capitalization.
TracksDemo/Shared/CrashLoggingDataSource.swift Updates the demo data provider to reference SentryConfig.sentryDSN.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants