Harden submit-form session cookies#2945
Merged
Merged
Conversation
Strengthen the token used for resuming an in-progress submission and set HttpOnly, SameSite=Lax, and Secure (under HTTPS) on the related cookies. Matching attributes are applied at the deletion sites so the cookies are still cleared correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening for the cookie-based "resume an in-progress submission" flow on the frontend job submission form.
HttpOnly,SameSite=Lax, andSecure(under HTTPS) on the related cookies.Details intentionally omitted; happy to discuss privately.
Test plan
Set-Cookieheaders includeHttpOnlyandSameSite=Lax(andSecureover HTTPS)._submitting_keypost meta.?new=1clears both cookies from the browser.SameSite=Lax); existing draft is not modified.