Allow filtering the TTL for matching ad codes#111
Merged
Conversation
GaryJones
approved these changes
Mar 15, 2022
Collaborator
|
Thanks, @dlh01! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the VIP Go environment, pages are typically cached in Varnish for 30 minutes, but Ad Code Manager currently caches matching ad codes for only 10 minutes, meaning the cache is likely to expire before it can be reused.
Because cache keys are derived from the current query vars, each ad code gets a new cache key for essentially every page, which starts to add up to a lot of infrequently reused cache keys on a high-traffic site with many ad codes.
This PR allows the cache TTL to be filtered to a value higher than 10 minutes, or, alternatively, to
false, which causes the matching ad code to be cached only in memory.