Conversation
- Make the testcase extend from the WP-Test-Utils testcase. - Rename the file containing the tests to PSR-4 (needed for PHPUNit 10 support) - Update assertions, including not using assertions that no longer exist. - Rename tests to use snake_case, so they read better with the Testdox format. - Update the bootstrap to work with WP Test Utils. - Add PHPUnit's cache file to .gitignore. - Update the composer test script. - Move integration test-related files into a new tests/Integrations directory, to allow for future unit tests as well. - Refresh PHPUnit config file for PHPUnit 9 and best practices.
- Test multiple PHP versions. - Allows for not checking PHPUnit XML file for PHP 7.1, as that uses PHPUnit 7.5, which doesn’t support testdox and coverage elements.
GaryJones
added
the
type: maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125.
Updates Integration tests and Linting workflows as well, to test against multiple PHP and WP versions.