Exclude eslint from Dependabot dev-dependencies group#919
Merged
Conversation
The `eslint*` pattern in the Dependabot group causes major eslint version bumps to be bundled with unrelated WordPress package updates. Since `@automattic/eslint-plugin-wpvip` does not yet support eslint v10, this blocks the entire group from merging (see #903). Excluding the bare `eslint` package lets it get its own PR while `eslint-*` plugins remain grouped.
GaryJones
added
the
type: maintenance
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #903 bundles an eslint v9-to-v10 major version bump alongside routine WordPress package updates. Because
@automattic/eslint-plugin-wpvip(up to its latest release, v1.2.0) still requirespeer eslint@"^9.7.0", the entire grouped PR failsnpm ciwith anERESOLVEconflict, blocking the otherwise harmless WordPress updates from landing.This adds an
exclude-patternsentry for the bareeslintpackage in the npm Dependabot group. Theeslint*glob still matches eslint plugins (e.g.eslint-plugin-*,eslint-config-*), so they remain grouped as before. Theeslintpackage itself will get its own standalone PR, making the peer dependency conflict visible and isolated rather than blocking unrelated updates.Once
@automattic/eslint-plugin-wpvipreleases eslint v10 support, the standalone eslint PR will pass CI and can be merged independently.Test plan
eslintand for the@wordpress/*group