Improve local wp-admin responsiveness#3377
Open
chubes4 wants to merge 2 commits into
Open
Conversation
Collaborator
📊 Performance Test ResultsComparing f38397b vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
Author
|
@fredrikekelund What do you think of this approach for The idea is to keep passive I added a small |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3367
Performance evidence
The main bottleneck found was fresh/passive wp-admin requests blocking on opportunistic WordPress.org checks. Explicit update/install/plugin/theme pages are intentionally excluded so user-requested live data still loads normally.
Dashboard/request-profiler baseline:
/wp-admin/PHP request: ~1608 ms/var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/studio-dashboard-profile-baseline-jipGCw/summary.jsonDashboard after scoped deferral:
/wp-admin/PHP request: ~149 ms/var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/studio-dashboard-profile-dashboard-scoped-8XmOjZ/summary.jsonBroad admin cold-page probe:
posts: 1.72 s -> 0.93 splugins.phpandplugin-install.phpstill perform their live checks by design/var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/studio-broad-admin-broad-admin-normal-normal-ibRqqe/summary.json/var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/studio-broad-admin-broad-admin-passive-defer-normal-bQmeEq/summary.jsonSite Editor A/B:
measure_site_editor_ready_ms: 1113, 1141, 1304; median 1141 msmeasure_site_editor_ready_ms: 1120, 1210, 1226; median 1210 mssite-editor.loadmetric/var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/studio-site-editor-ab-baseline-i7b9XP/summary.json/var/folders/lr/c_cmmt7s0592m4njz99v5yb40000gn/T/studio-site-editor-ab-patched-o5YpgM/summary.jsonWooCommerce probe:
Diagnostic tooling used:
Testing
npm run test -- --project common -- tools/common/lib/tests/mu-plugins.test.tsnpm run test -- --project studio -- apps/studio/src/lib/tests/site-maintenance-tasks.test.ts apps/studio/src/lib/tests/background-tasks.test.ts apps/studio/src/lib/tests/capture-site-thumbnail.test.ts apps/studio/src/modules/cli/lib/tests/cli-events-subscriber.test.tsnpm -w studio-app run typechecknpm -w studio-app run lintAI assistance