Make phpMyAdmin work with native PHP runtime#3426
Merged
Merged
Conversation
…691-sane-security-defaults
This reverts commit ffe41e7.
…691-sane-security-defaults
…nescaping' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…691-sane-security-defaults
fredrikekelund
commented
May 20, 2026
Contributor
Author
There was a problem hiding this comment.
This file is a straight up copy of the Playground source code
bcotrim
approved these changes
May 20, 2026
Contributor
bcotrim
left a comment
There was a problem hiding this comment.
Works as described
LGTM 👍
Collaborator
📊 Performance Test ResultsComparing 1941be0 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
I used Codex to help me understand how Playground makes phpMyAdmin work. Once I had a 90% understanding and a relatively clear idea of what I thought the Studio implementation should look like, I asked Codex for the implementation, which I then tweaked to simplify.
Proposed Changes
native-phpruntime.DbiMysqli.phpandconfig.inc.phpfrom the Playground repo./internal/shared/wp-env.php). With the native PHP runtime, we obviously don't have this, so we generate temp files and pass the site-specific paths to the PHP process using environment variables.Testing Instructions
STUDIO_RUNTIME=native-php npm startnative-phpruntime (if you're unsure, just create a new site – it will automatically be assigned this runtime when Studio is run withSTUDIO_RUNTIME=native-php)Pre-merge Checklist