fix: harden orchestration state recovery - #136
Merged
Merged
Conversation
Reordering escalation ahead of dispatched_for_sha? reopened a race where the poll right after the final retry's dispatch could escalate before the agent reached "running", abandoning it. Hold escalation off for a grace window after a dispatch lands (until rework_in_progress?/2 takes over). Also: dedupe workspace key sanitization via Workspace.safe_identifier, refresh the stale prefetch comment, and cover the Linear-transition-failure durability path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Rework dispatch could lose durable context or get stuck after transition failures, and multi-repo startup cleanup missed secondary repos.
TL;DR
Make rework state changes durable before dispatch and recover cleanly after restarts.
Summary
Alternatives
Test Plan
make allmix test test/symphony_elixir/ci_poller_test.exs test/symphony_elixir/pr_review_poller_test.exs test/symphony_elixir/config_split_test.exs test/symphony_elixir/orchestrator_status_test.exsmix specs.check