fix(pr-review): post auto-reply outside the rework-only path - #71
Merged
Conversation
Summary: - Require posting `github_reply_to_review_comment` in WORKFLOW.md when addressing review comments in code, not just for pushback. - Lift the `status == "rework_requested"` gate in `complete_reviewer_comment_record/2`: any pr_review record with `pending_reviewer_comments` now completes (auto-replies if enabled and advances the addressed cursor). - Update the existing "ignores pending comments unless waiting for rework" test to assert the new contract and add a focused test that auto-reply fires for non-rework statuses with pending comments. Rationale: - Copilot review comments that arrive during the initial agent run (before the issue reaches `In Review`) were addressed in code but never replied to, because the poller had no rework cycle to drive the auto-reply and WORKFLOW.md only required a reply for pushback. - The agent-side change catches the same-run-as-PR-open case; the poller change is defense-in-depth for cooling-down/deferred/non- rework records that still carry pending comments. Tests: - mix test test/symphony_elixir/pr_review_poller_test.exs - mix test test/symphony_elixir/core_test.exs - mix specs.check - mix format --check-formatted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR review comments that land during the initial agent run (before the issue reaches
In Review) get addressed in code but never replied to, leaving threads silently resolved. See #67 (comment) for a recent example.TL;DR
Tighten WORKFLOW.md to require a reply on every addressed comment and let the poller's auto-reply fire for non-rework records.
Summary
WORKFLOW.mdPR feedback sweep protocol so addressed-in-code requires agithub_reply_to_review_comment, not just pushback.status == "rework_requested"gate incomplete_reviewer_comment_record/2; any record withpending_reviewer_commentsnow completes (auto-reply if enabled, cursor advanced).Alternatives
Test Plan
make allmix test test/symphony_elixir/pr_review_poller_test.exsmix test test/symphony_elixir/core_test.exsmix specs.checkmix format --check-formatted