Skip to content

Fix releases schema#3

Merged
joaopamaral merged 4 commits into
masterfrom
fix_releases_schema
Jun 27, 2023
Merged

Fix releases schema#3
joaopamaral merged 4 commits into
masterfrom
fix_releases_schema

Conversation

@joaopamaral
Copy link
Copy Markdown

@joaopamaral joaopamaral commented Jun 27, 2023

Description of change

Removing discussion_url format since it should be uri and not date-time according to API docs https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28

Manual QA steps

  • Manually tested using meltano cli.
meltano elt tap-github target-jsonl --select releases

Risks

Rollback steps

  • revert this branch

@joaopamaral joaopamaral requested a review from a team June 27, 2023 15:01
Comment thread setup.py

setup(name='tap-github',
version='2.0.0',
version='2.0.3',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big jump....

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to bump in the previous PRs (but the release was correct). 😅

@joaopamaral joaopamaral merged commit e6aa4b7 into master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants