Skip to content

Fixed bug in localStorage's state persistence logic#108

Merged
markbiek merged 1 commit into
masterfrom
fix/localstorage-state
Oct 12, 2023
Merged

Fixed bug in localStorage's state persistence logic#108
markbiek merged 1 commit into
masterfrom
fix/localstorage-state

Conversation

@nelsonec87
Copy link
Copy Markdown
Contributor

This PR fixes a problem where the state is never saved to localStorage.

Now, every time the state changes, the state is marked to be persisted.

This has the immediate advantage of persisting the API, version, and URL in the header between sessions.

Before:
image

After:
image

Copy link
Copy Markdown
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@markbiek
Copy link
Copy Markdown
Member

@dmsnell Nelson is now on parental leave.

Are you OK with me merging this? Is there anything special I need to do beyond clicking the "Squash and merge" button?

@dmsnell
Copy link
Copy Markdown
Member

dmsnell commented Oct 12, 2023

I can't remember, @markbiek - setting myself a reminder to try and look into this tomorrow in case that doesn't deploy the code.

@markbiek markbiek merged commit cfbc7ff into master Oct 12, 2023
@markbiek markbiek deleted the fix/localstorage-state branch October 12, 2023 17:53
@markbiek
Copy link
Copy Markdown
Member

I can't remember, @markbiek - setting myself a reminder to try and look into this tomorrow in case that doesn't deploy the code.

Great, thanks! I'll set a reminder to do the same.

@markbiek
Copy link
Copy Markdown
Member

@dmsnell It doesn't seem like this deployed.

@dmsnell
Copy link
Copy Markdown
Member

dmsnell commented Oct 13, 2023

@markbiek I think the instructions in the README.md will work for you. Poke me here if you have further trouble. Sorry I should have checked on this yesterday I guess, but I didn't know the answer was right there in front of us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants