Fixed bug in localStorage's state persistence logic#108
Merged
Conversation
Member
|
@dmsnell Nelson is now on parental leave. Are you OK with me merging this? Is there anything special I need to do beyond clicking the "Squash and merge" button? |
Member
|
I can't remember, @markbiek - setting myself a reminder to try and look into this tomorrow in case that doesn't deploy the code. |
Member
Great, thanks! I'll set a reminder to do the same. |
Member
|
@dmsnell It doesn't seem like this deployed. |
Member
|
@markbiek I think the instructions in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where the state is never saved to
localStorage.Now, every time the state changes, the state is marked to be persisted.
This has the immediate advantage of persisting the API, version, and URL in the header between sessions.
Before:

After:
