Conversation
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
|
Design System Reference Site Preview: https://6a8f0fe7-preview.a8cds.workers.dev (Latest commit: a7767dc) |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
| } ); | ||
|
|
||
| expect( screen.getByText( 'Type' ) ).toBeInTheDocument(); | ||
| expect( screen.getByText( /Type/ ) ).toBeInTheDocument(); |
There was a problem hiding this comment.
Type field is now marked as (Optional) because it's the minority (see: WordPress/gutenberg#74430)
| Before | After |
|---|---|
![]() |
![]() |
Why is this not a breaking change 😅 thanks, nice catch, I'll try to figure it out... |
|
Might be related to WordPress/gutenberg#74572. I didn't think that effected the initial loading state though. |
Yeah, it seems to be a regression. Asked here: p1773398941002369-slack-C05QAFZSFTL. Looks like it's blocking this upgrade 😬 |
|
Should be good to review again; the bug has been fixed in 13.1.0. |
StevenDufresne
left a comment
There was a problem hiding this comment.
I did a smoke test. I didn't find any noticeable regressions. Thanks for this!




Fixes DOTMSD-128
Proposed Changes
Upgrade DataViews to version
13.0.013.1.0.The CSS changes in this PR are done to satisfy the breaking changes note:
Why are these changes being made?
I want to apply the new "Reset view" styles from WordPress/gutenberg#75093. (Note: it will need a follow-up change after this PR)
Testing Instructions
Open MSD/Calypso/Reader, and verify DataViews pages still look good (no regressions).
Pre-merge Checklist