Skip to content

Upgrade DataViews to 13.1.0#109190

Merged
fushar merged 1 commit intotrunkfrom
dataviews-13
Mar 20, 2026
Merged

Upgrade DataViews to 13.1.0#109190
fushar merged 1 commit intotrunkfrom
dataviews-13

Conversation

@fushar
Copy link
Contributor

@fushar fushar commented Mar 11, 2026

Fixes DOTMSD-128

Proposed Changes

Upgrade DataViews to version 13.0.0 13.1.0.

The CSS changes in this PR are done to satisfy the breaking changes note:

The design tokens stylesheet (@wordpress/theme/design-tokens.css) is no longer embedded in the DataViews stylesheet. Applications using DataViews outside of WordPress must now explicitly include the design tokens stylesheet. See the README for installation instructions. WordPress/gutenberg#75182

Why are these changes being made?

I want to apply the new "Reset view" styles from WordPress/gutenberg#75093. (Note: it will need a follow-up change after this PR)

Testing Instructions

Open MSD/Calypso/Reader, and verify DataViews pages still look good (no regressions).

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Design System Reference Site Preview:

https://6a8f0fe7-preview.a8cds.workers.dev

(Latest commit: a7767dc)

@fushar fushar self-assigned this Mar 11, 2026
@matticbot
Copy link
Contributor

matticbot commented Mar 11, 2026

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug dataviews-13 on your sandbox.

} );

expect( screen.getByText( 'Type' ) ).toBeInTheDocument();
expect( screen.getByText( /Type/ ) ).toBeInTheDocument();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type field is now marked as (Optional) because it's the minority (see: WordPress/gutenberg#74430)

Before After
Image Image

@fushar fushar marked this pull request as ready for review March 11, 2026 04:55
@fushar fushar requested review from a team as code owners March 11, 2026 04:55
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 11, 2026
@StevenDufresne
Copy link
Contributor

The change to loading states are impacting views that don't ensure data.

Before After
Screen Recording on 2026-03-11 at 02-07-53 Screen Recording on 2026-03-11 at 02-09-12

@fushar
Copy link
Contributor Author

fushar commented Mar 11, 2026

The change to loading states are impacting views that don't ensure data.

Why is this not a breaking change 😅 thanks, nice catch, I'll try to figure it out...

@StevenDufresne
Copy link
Contributor

Might be related to WordPress/gutenberg#74572. I didn't think that effected the initial loading state though.

@fushar
Copy link
Contributor Author

fushar commented Mar 13, 2026

Might be related to WordPress/gutenberg#74572. I didn't think that effected the initial loading state though.

Yeah, it seems to be a regression. Asked here: p1773398941002369-slack-C05QAFZSFTL. Looks like it's blocking this upgrade 😬

@fushar fushar changed the title Upgrade DataViews to 13.0.0 Upgrade DataViews to 13.1.0 Mar 19, 2026
@fushar
Copy link
Contributor Author

fushar commented Mar 19, 2026

Should be good to review again; the bug has been fixed in 13.1.0.

Copy link
Contributor

@StevenDufresne StevenDufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a smoke test. I didn't find any noticeable regressions. Thanks for this!

@fushar fushar merged commit 8ef5672 into trunk Mar 20, 2026
15 checks passed
@fushar fushar deleted the dataviews-13 branch March 20, 2026 02:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants