A4A: Remove dead code with hardcoded boolean variables#109224
Merged
jkguidaven merged 3 commits intotrunkfrom Mar 12, 2026
Merged
A4A: Remove dead code with hardcoded boolean variables#109224jkguidaven merged 3 commits intotrunkfrom
jkguidaven merged 3 commits intotrunkfrom
Conversation
The showLearnMoreLink variable was hardcoded to false with a FIXME comment in both license-list/empty and revoke-license-dialog. Remove the unreachable conditional blocks and unused Gridicon import. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The variable was hardcoded to true with a FIXME comment in three files. Remove it and simplify the Button props accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The variable was hardcoded to true with a TODO comment. Remove it and render programLinks directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: pfSQfS-1sJ-p2
Proposed Changes
This pull request primarily removes temporary feature flags and placeholder logic related to program links, license issuing, and "Learn more" links throughout the partner directory and billing UI. The changes simplify the codebase by eliminating unused variables and conditionals, ensuring that program links and license issuing buttons are always shown, and removing placeholder "Learn more" links that were not yet implemented.
Key changes include:
Removal of temporary feature flags and placeholder logic:
displayProgramLinksflag and now always displayprogramLinksin the partner directory dashboard (index.tsx). [1] [2] [3]partnerCanIssueLicenseflag and related conditionals; the "Issue new license" button is now always enabled and links directly to the marketplace in billing and licenses UI components (billing-dashboard.tsx,license-list/empty.tsx,licenses-overview/index.tsx). [1] [2] [3] [4] [5] [6]Cleanup of placeholder "Learn more" links:
empty.tsx,revoke-license-dialog/index.tsx). [1] [2]Minor code cleanup:
Gridicon) from the license list empty state component (empty.tsx).Why are these changes being made?
Ensures our codebase are maintainable by removing irrelevant codes.
Testing Instructions
Pre-merge Checklist