A4A: Remove a4a-unified-onboarding-tour feature flag#109327
Open
jkguidaven wants to merge 1 commit intotrunkfrom
Open
A4A: Remove a4a-unified-onboarding-tour feature flag#109327jkguidaven wants to merge 1 commit intotrunkfrom
jkguidaven wants to merge 1 commit intotrunkfrom
Conversation
The flag was enabled in all environments (production, development, stage, horizon). Hardcode the enabled behavior and remove dead code paths including intro-cards, quick-links, and feature-announcement components that were gated behind the flag.
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: pfSQfS-1sJ-p2
Proposed Changes
This pull request removes the "a4a-unified-onboarding-tour" feature flag and all related conditional logic, fully enabling the unified onboarding tour and cleaning up legacy onboarding code and UI. It also removes onboarding and quick links components that are no longer needed, simplifying the codebase and user interface.
Key changes include:
Feature flag and conditional logic removal:
a4a-unified-onboarding-tourfeature flag from all configuration files, making the unified onboarding tour always enabled. [1] [2] [3] [4]isEnabled('a4a-unified-onboarding-tour')and updated redirects and UI logic to assume the unified onboarding tour is always active. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Component and UI cleanup:
OverviewBodyIntroCardsand its usage, along with its styles. [1] [2] [3]AgencyTierFeatureAnnouncementmodal and its conditional display logic, as it is no longer needed with the unified onboarding experience. [1] [2] [3]Why are these changes being made?
Ensures our codebase are maintainable by removing irrelevant codes.
Testing Instructions
/overviewpage.Pre-merge Checklist