MSD Billing: Fix atomic plan revert confirmation checkbox

[chrismccluskey]

Fixes CHE-457

Proposed Changes

• Resolve an issue where Atomic plans with bundled domains could not be cancelled because the checkbox did not enable the remove button.

Why are these changes being made?

• The application is expecting atomicRevertConfirmed to be true if the checkbox was checked, but this wasn't being set.

Testing Instructions

• Try to remove a plan purchased with a domain for a site that has gone atomic in the MSD.
• Check the checkbox to confirm that you understand your plan will change.
• The "Remove" button should change from a disabled state to an enabled state.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-172750

Jetpack Cloud Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-172750&env=jetpack

Automattic for Agencies Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-172750&env=a8c-for-agencies

Dashboard Live (dotcom) (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-172750&env=dashboard

Dashboard Live (CIAB) (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-172750&env=dashboard-ciab

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• agents-manager
• blaze-dashboard
• help-center
• notifications
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/msd-at-plan-revert-confirmation on your sandbox.

[chrismccluskey]

I'm explicitly calling both functions here, but I could just as easily only call the atomic plan revert function in the if ( atomicTransfer?.created_at ) block and remove the return. My concern is that doing so will rely on that return not being present when it might normally look like it should be given how the functions are named.

[sirbrillig]

The code seems fine, and testing works as described, but... it also works without this PR.

Trying to cancel the Business plan subscription for my Atomic site (192446221):

Is there something else I need to do to trigger the bug?

[chrismccluskey]

The code seems fine, and testing works as described, but... it also works without this PR.

My mistake. This needs to be tested on an atomic site with a bundled domain. I have updated the PR description and testing instructions to reflect this.

[sirbrillig]

Looks good!