Skip to content

Minor fix to not break word-break in advertising action buttons#109415

Merged
therocket-gr merged 1 commit intotrunkfrom
vdimitrakis/hotfix/add-whitespace-no-wrap-in-promote-button
Mar 20, 2026
Merged

Minor fix to not break word-break in advertising action buttons#109415
therocket-gr merged 1 commit intotrunkfrom
vdimitrakis/hotfix/add-whitespace-no-wrap-in-promote-button

Conversation

@therocket-gr
Copy link
Contributor

Part of #
No linear ticket. just a quick hot fix

Proposed Changes

Add word-break normal in promote buttons

Why are these changes being made?

I noticed that in blaze (using jetpack) there is a breaking word on this button

Screenshot 2026-03-20 at 10 48 08

also appears here (when the browser width is narrow)

Screenshot 2026-03-20 at 10 49 02

this PR will fix the issue

Testing Instructions

CR is enough i think. But in order to test it out

I cant spot this in normal calypso.. only jetpack seems to have the bug,

You can just checkout the branch and sync to your sandbox using

yarn dev --sync

check a jetpack connected site (add hosts to widgets.wp.com)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@therocket-gr therocket-gr requested a review from jjolmo March 20, 2026 08:52
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 20, 2026
@therocket-gr therocket-gr requested a review from j6ll March 20, 2026 08:52
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug vdimitrakis/hotfix/add-whitespace-no-wrap-in-promote-button on your sandbox.

Copy link
Member

@j6ll j6ll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therocket-gr therocket-gr merged commit 8c62d99 into trunk Mar 20, 2026
15 checks passed
@therocket-gr therocket-gr deleted the vdimitrakis/hotfix/add-whitespace-no-wrap-in-promote-button branch March 20, 2026 09:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants