Merged
Conversation
jacobperron
reviewed
Apr 4, 2022
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Thanks, looks reasonable to me.
Could you add a note about this workaround/API to the README? The Known Issues section seems like a good place.
Member
|
Also, feel free to add yourself to the contributors list :) |
* Add note about 600 series OI mode reporting bug to Known Issues section and include details of API workaround option. * Add myself to contributors list
Contributor
Author
|
No problem! I've added details regarding the OI mode issue and workaround to the README. |
Member
|
Thanks for the contribution! |
process1183
added a commit
to process1183/roomba-rpi
that referenced
this pull request
Apr 28, 2022
The OI mode reporting bug workaround option was merged: AutonomyLab/libcreate#67 AutonomyLab/create_robot#95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of a simple flag to correct the off-by-one error for the mode present in the sensor stream of some 6xx Roomba models.
Ref: github.com/AutonomyLab/create_robot/issues/64