Skip to content

fix(peer-demo-showcase): add ID validation to prevent injection vulne… #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avad05 merged 1 commit into from
Jul 27, 2026
Merged

fix(peer-demo-showcase): add ID validation to prevent injection vulne… #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions kits/peer-demo-showcase/apps/actions/orchestrate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,30 @@ function escapeHtml(str: string): string {
.replace(/'/g, ''');
}

/**
* Strictly validates server-issued identifier format before interpolation into flow WHERE predicates.
* Rejects any ID containing quotes, spaces, SQL delimiters, or non-alphanumeric characters.
*/
function validateId(id: string): string {
if (typeof id !== 'string' || !/^[a-zA-Z0-9_-]+$/.test(id)) {
throw new Error('Invalid identifier format');
}
return id;
}

/**
* Sanitizes input strings before passing them to Lamatic flow executions.
* Escapes quotes, backslashes, and newlines so that Lamatic template interpolation
* into flow JSON node definitions (e.g. `{{triggerNode_1.output.param}}`) remains valid JSON.
* Escapes double quotes, single quotes, backslashes, and newlines so that Lamatic template interpolation
* into flow JSON node definitions (e.g. `{{triggerNode_1.output.param}}`) remains valid JSON and safe for WHERE predicates.
*/
function sanitizeFlowInput(val: string): string {
if (typeof val !== 'string') return val;
return val.replace(/\\/g, '\\\\').replace(/"/g, '\\"').replace(/\n/g, '\\n').replace(/\r/g, '\\r');
return val
.replace(/\\/g, '\\\\')
.replace(/"/g, '\\"')
.replace(/'/g, "\\'")
.replace(/\n/g, '\\n')
.replace(/\r/g, '\\r');
}

async function sendConfirmationEmail(options: EmailOptions) {
Expand Down Expand Up @@ -388,7 +404,7 @@ export async function updateProjectStatus(id: string, status: string) {
const flowId = process.env.LAMATIC_SUBMISSIONS_MANAGER_FLOW_ID || process.env.LAMATIC_UPDATE_STATUS_FLOW_ID;
if (flowId) {
try {
await lamaticClient.executeFlow(flowId, { action: 'update_status', id: sanitizeFlowInput(id), status: sanitizeFlowInput(status) });
await lamaticClient.executeFlow(flowId, { action: 'update_status', id: validateId(id), status: sanitizeFlowInput(status) });
} catch (err: any) {
console.warn('Lamatic updateProjectStatus executeFlow failed:', err.message);
}
Expand All @@ -409,7 +425,7 @@ export async function updateProjectSponsor(id: string, matched_sponsor: string)
const flowId = process.env.LAMATIC_SUBMISSIONS_MANAGER_FLOW_ID || process.env.LAMATIC_UPDATE_STATUS_FLOW_ID;
if (flowId) {
try {
await lamaticClient.executeFlow(flowId, { action: 'update_sponsor', id: sanitizeFlowInput(id), matched_sponsor: sanitizeFlowInput(matched_sponsor) });
await lamaticClient.executeFlow(flowId, { action: 'update_sponsor', id: validateId(id), matched_sponsor: sanitizeFlowInput(matched_sponsor) });
} catch (err: any) {
console.warn('Lamatic updateProjectSponsor executeFlow failed:', err.message);
}
Expand Down Expand Up @@ -442,7 +458,7 @@ export async function resubmitProject(
if (updateFlowId) {
try {
await lamaticClient.executeFlow(updateFlowId, {
id: sanitizeFlowInput(id),
id: validateId(id),
github_url: sanitizeFlowInput(hostedLink ? `${githubUrl}|${hostedLink}` : githubUrl),
project_title: sanitizeFlowInput(newMatch.project_title),
category: sanitizeFlowInput(newMatch.category),
Expand Down Expand Up @@ -475,7 +491,7 @@ export async function upvoteProject(id: string, currentCount: number = 0) {
const upvoteFlowId = process.env.LAMATIC_SUBMISSIONS_MANAGER_FLOW_ID || process.env.LAMATIC_UPVOTE_PROJECT_FLOW_ID;
if (upvoteFlowId) {
try {
await lamaticClient.executeFlow(upvoteFlowId, { action: 'upvote', id: sanitizeFlowInput(id), upvotes: newUpvotes });
await lamaticClient.executeFlow(upvoteFlowId, { action: 'upvote', id: validateId(id), upvotes: newUpvotes });
} catch (err: any) {
console.warn('Lamatic upvoteProject executeFlow failed:', err.message);
}
Expand Down Expand Up @@ -553,7 +569,7 @@ export async function deleteSubmission(id: string) {
const deleteFlowId = process.env.LAMATIC_SUBMISSIONS_MANAGER_FLOW_ID || process.env.LAMATIC_DELETE_SUBMISSION_FLOW_ID;
if (deleteFlowId) {
try {
await lamaticClient.executeFlow(deleteFlowId, { action: 'delete', id: sanitizeFlowInput(id) });
await lamaticClient.executeFlow(deleteFlowId, { action: 'delete', id: validateId(id) });
} catch (err: any) {
console.warn('Lamatic deleteSubmission executeFlow failed:', err.message);
}
Expand Down