Skip to content

fix: bump session lock wait to 3s so slow I/O does not race duplicates #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
George-iam merged 1 commit into from
Apr 17, 2026
Merged

fix: bump session lock wait to 3s so slow I/O does not race duplicates #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/storage/sessions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,13 @@ export function clearLegacyActiveSession(projectPath: string): void {
* Stale lock (>5s) auto-cleaned to handle crashed lock holders.
*/
const LOCK_STALE_MS = 5_000;
const LOCK_WAIT_MS = 500;
// Bounded by the PreToolUse hook's 5-second timeout in .claude/settings.json —
// leave ~2s headroom for the rest of the hook work after the lock is released.
// The previous 500ms was too tight on slow I/O (WSL2, busy SSDs) where a
// lock-holder could still be writing its mapping when waiters timed out and
// each then created a duplicate session. LOCK_STALE_MS > LOCK_WAIT_MS keeps
// the stale-lock recovery path independent of normal contention.
const LOCK_WAIT_MS = 3_000;
const LOCK_POLL_MS = 50;

// Exported for testing
Expand Down