Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 97.25% 97.22% -0.04%
==========================================
Files 10 11 +1
Lines 1421 1979 +558
==========================================
+ Hits 1382 1924 +542
- Misses 39 55 +16 ☔ View full report in Codecov by Sentry. |
3 tasks
Owner
Author
|
BVH point queries are in the process of being upstreamed here: svenstaro/bvh#108 |
Owner
Author
|
As the upstream PR has not been active for the last two monthes, with no update from the maintainer, I'm merging this one to get the benefits of the new BVH in this crate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_sdfnow takes aAccelerationMethodparameter, that can be eitherAccelerationMethod::Bvh(default) orAccelerationMethod::None.Bvhis recommended unless you're really tight on memory or your query is very small (couple hundreds of queries and triangles).For example, a query of 15k points with 100k triangles is 10 times faster with a bvh, and twice faster for 500 queries and 10k triangles.
Bvhis also optimised for theSignMethod::Raycastsign method.