Final bigfield audit PR with a few circuit changes. Modifications that don't change circuits: - Change `MAXIMUM_LIMB_SIZE_THAT_WOULDNT_OVERFLOW = 86` from `87` (explained in the code-comment). This only reduces our safety-margin slightly, but we're already way below this so does not affect anything. - Removed duplicated code and added a new function `compute_partial_schoolbook_multiplication` to compute native limb multiplication with documentation - Refactored duplicated code to generate inputs to bigfield addition and subtraction gates, should avoid copy-pasting! Modifications that change circuits: - Simplified `bigfield::conditional_negate` logic by just using `bigfield::conditional_assign` without adding new gates. Note: Custom logic of `bigfield::conditional_negate` had a bug in max value calculations. - Simplified `bigfield::conditional_select` using `field::conditional_assign` instead of manually using `field_t::madd` and subtraction. resolves #14657 #14656 #14661 resolves AztecProtocol/barretenberg#660 resolves #15091 resolves #15088

[barretenberg] Improve efficiency of bigfield pow #15091

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions