This is a retroactive issue. The PR has been made here
Problem
The bb-bin-tests are testing the cli version of our typescript code, formally known as bb.js. The build-system was not including the typescript folder as part of the rebuild pattern, so changes to the typescript folder would not trigger the bb-bin-tests to run.
Partial Solution
Since bb.js is always rebuilt in the CI when the typescript folder changes, we can run the bb-bin-test there.
This is what the linked PR is doing, but its not ideal because there are two other jobs which wait for bb.js to build before running its tests; bb-js-test and barretenberg-acir-tests.
Ideal Solution
bb-bin-test is a separate job which relies on the build step of bb.js.
This was attempted however we settled on the less than ideal solution above, given that these tests are only ran when barretenberg or the typescript folder changes.
This is a retroactive issue. The PR has been made here
Problem
The bb-bin-tests are testing the cli version of our typescript code, formally known as bb.js. The build-system was not including the typescript folder as part of the rebuild pattern, so changes to the typescript folder would not trigger the bb-bin-tests to run.
Partial Solution
Since bb.js is always rebuilt in the CI when the typescript folder changes, we can run the bb-bin-test there.
This is what the linked PR is doing, but its not ideal because there are two other jobs which wait for bb.js to build before running its tests; bb-js-test and barretenberg-acir-tests.
Ideal Solution
bb-bin-test is a separate job which relies on the build step of bb.js.
This was attempted however we settled on the less than ideal solution above, given that these tests are only ran when barretenberg or the typescript folder changes.