Generator `ASSERT` should be failing for wasm but is ignored

[dbanks12]

Assertions should be failing for wasm relating to generator indices, but ASSERT does nothing in wasm.

When you build for --preset wasm with -DCMAKE_BUILD_TYPE=Debug (set during cmake configure or in wasm preset), it makes ASSERT work. Turns out the following assertion is failing for wasm, but it only materializes when in debug mode:

    ASSERT(index.sub_index < num_generators_per_hash_index);

Assertion is here in get_generator_data.

In a non-debug build (when assertions are ignored), get_generator_data is called with index.sub_index = 34 while num_generators_per_hash_index is a constant 16 for wasm.

To replicate:

# checkout master
cd circuits/cpp
cmake --preset wasm -DCMAKE_BUILD_TYPE=Debug && cmake --build --preset wasm --target aztec3_circuits_abis_tests
wasmtime --dir .. ./build-wasm/bin/aztec3_circuits_abis_tests --env GTEST_FILTER=*.hash_vk*

[rahul-kothari]

for circuits, you will have to use DummyComposer

[iAmMichaelConnor]

Would the fix be to also run a version of the CI tests with this Debug flag?

[dbanks12]

That would catch errors in tests which is a big step. But it still could silently fail in production.

[iAmMichaelConnor]

From call just now: let's wait until we're using UltraPlonk (#305 )
Once that's in, this particular error won't be triggered anymore, and we can run CI in this wasm-debug mode.
A separate (much larger) task, which should be opened in the bberg repo, is to change all c_binds to return error status.