chore: align AVM witgen's limits on number of side effects with AVM simulator. Witgen supports phases and rollbacks.#10329
Merged
IlyasRidhuan merged 7 commits intoDec 3, 2024
Conversation
dbanks12
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
dbanks12
changed the base branch from
master
to
ir/11-28-feat_enqueued_call_side_effect_trace
dbanks12
changed the title
IlyasRidhuan
pushed a commit
that referenced
this pull request
Dec 3, 2024
…imulator. Witgen supports phases and rollbacks. (#10329) 1. Aligns side effect limits between TS and CPP 2. Adds Noir test functions to spam side effects & adds that to proving test 2. Adds support to witgen for tx phases 3. Never expects a read hint for nullifier writes. Always just uses the write hint. 4. Adds an argument to finalize and `gen_trace` to skip end-gas assertions (not sure this is the best way, but all the tests pass) 5. renames TS hint vectors to all just be `*_reads` or `*_writes` instead of `*read/update_requests` etc. Work needed in a follow-up PR: - separate the opcode switch-case & phase management/enqueued-calls into separate functions or even separate files in witgen
IlyasRidhuan
pushed a commit
that referenced
this pull request
Dec 9, 2024
…imulator. Witgen supports phases and rollbacks. (#10329) 1. Aligns side effect limits between TS and CPP 2. Adds Noir test functions to spam side effects & adds that to proving test 2. Adds support to witgen for tx phases 3. Never expects a read hint for nullifier writes. Always just uses the write hint. 4. Adds an argument to finalize and `gen_trace` to skip end-gas assertions (not sure this is the best way, but all the tests pass) 5. renames TS hint vectors to all just be `*_reads` or `*_writes` instead of `*read/update_requests` etc. Work needed in a follow-up PR: - separate the opcode switch-case & phase management/enqueued-calls into separate functions or even separate files in witgen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_traceto skip end-gas assertions (not sure this is the best way, but all the tests pass)*_readsor*_writesinstead of*read/update_requestsetc.Work needed in a follow-up PR: