chore: added package version string for sandbox#10687
Conversation
|
@FilipHarald your issue stated you wanted it for node but this only does for sandbox (`aztec start --sandbox) and not if you create a node independently. Is that your intention? |
| const sandboxOptions = extractNamespacedOptions(options, 'sandbox'); | ||
| userLog(`${splash}\n${github}\n\n`); | ||
| const packageVersionString = `aztec-packages version: ${process.env.npm_package_version}`; | ||
| userLog(`${splash}\n${github}\n${packageVersionString}\n\n`); |
There was a problem hiding this comment.
@alexghr at some point we used to print the version but clearly we regressed. Do you know why? or is this ok?
There was a problem hiding this comment.
I think the version got lost in a refactor.
I'm not sure reading $npm_package_version is the right approach for this because it won't be set if running the script directly (not via npm/yarn).
Ah, yes, I specifically need it for the sandbox. And I did not fully understand the consequences of adding it to the node as well. But I would imagine this being good for node-operators as well. |
|
closing in favour of #10935 10935 |
Fixes underlying issue presented in #10687 Seems to have been removed during a refactor Note this is untested!
3 participants
resolves #10686
I've only added the version to when running the Sandbox since I have not run the node in any other mode. But this would probably help when running a node as well.