add wasm build step to circleci#109
Merged
Merged
Conversation
ludamad
approved these changes
Mar 29, 2023
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
* attempting to remove any call to bump_memory * add back in mistakenly removed fft * fixing some bump memory in PCS and poly mem store * ensuring no bump memory with assert and removing initial_size * removing allocated_pages and page_size * fix bad polynomial sizing in prover test * getting rid of the notion of max_size * removing some erroneous zero_memory calls in poly operators * fix bad sizing in poly arith test * doing away with the poly(size_t, size_t) constructor entirely * progress towards coherent size-capacity concept * fix after rebase * improving move operations with exchange and adding a coresponding test * addressing several of Adrians PR comments * restoring single instantiation of tmp poly in shplonk * remove size check from factor_roots test since size is no longer changed * default constructor, bad move operation, etc * allowing assignment after default construction * standardizing assertions in polynomial * fix return type on mapped
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
* attempting to remove any call to bump_memory * add back in mistakenly removed fft * fixing some bump memory in PCS and poly mem store * ensuring no bump memory with assert and removing initial_size * removing allocated_pages and page_size * fix bad polynomial sizing in prover test * getting rid of the notion of max_size * removing some erroneous zero_memory calls in poly operators * fix bad sizing in poly arith test * doing away with the poly(size_t, size_t) constructor entirely * progress towards coherent size-capacity concept * fix after rebase * improving move operations with exchange and adding a coresponding test * addressing several of Adrians PR comments * restoring single instantiation of tmp poly in shplonk * remove size check from factor_roots test since size is no longer changed * default constructor, bad move operation, etc * allowing assignment after default construction * standardizing assertions in polynomial * fix return type on mapped
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist: